feat: improve docs security jwt#22
Draft
tranduc2612 wants to merge 1 commit into
Draft
Conversation
nhattran998
requested changes
Jan 10, 2025
Member
nhattran998
left a comment
nhattran998
left a comment
There was a problem hiding this comment.
Please update your PR instead of using <b> --> using **
tranduc2612
force-pushed
the
feat/security/jwt
branch
from
accb872 to
d75e510
Compare
tranduc2612
force-pushed
the
feat/security/jwt
branch
from
d75e510 to
82ba880
Compare
tobiasmaitvf
reviewed
Feb 2, 2025
| }) | ||
|
|
||
| // Middleware to verify JWT | ||
| const authenticate = async (req, res, next) => { |
There was a problem hiding this comment.
This authenticate function won't help you when your user's token is stolen. In my point of view, you might need to give the users a warning about suspicious activities on their account if the devices or IPs used to access their accounts differ from their original ones
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.