Skip to content

Conversation

gliptak
Copy link

@gliptak gliptak commented Sep 7, 2025

@gliptak
Copy link
Author

gliptak commented Sep 9, 2025

@TibixDev please approve workflow run

@fat0troll
Copy link
Collaborator

Approved the workflow run.

Copy link
Collaborator

@fat0troll fat0troll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if the pull request build end up somewhere in artifacts so the author of the pull request could use them to test the changes in the provided build by themselves before asking for a merge.

UPD: found it, ignore this comment.

Copy link
Collaborator

@fat0troll fat0troll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, oops, I'm blind, found them: https://github.com/TibixDev/winboat/actions/runs/17530023679#artifacts

Could you add a step to the workflow that can post such a link to the pull request itself?

@Levev Levev added the CI/CD Anything regarding the CI/CD pipeline label Sep 10, 2025
@gliptak
Copy link
Author

gliptak commented Sep 11, 2025

thank you @fat0troll

could be modeled after https://github.com/open-turo/actions-go/blob/f1747e80b0dccc25f57c632099397a4ff522415d/prerelease/action.yaml#L186-L198

happy to work this as a followup PR

@gliptak gliptak requested a review from fat0troll September 11, 2025 13:36
@gliptak gliptak force-pushed the patch-2 branch 6 times, most recently from 7b4475f to 5374706 Compare September 13, 2025 21:08
@gliptak
Copy link
Author

gliptak commented Sep 13, 2025

@fat0troll updated with link posting

gliptak#1 (comment)

@gliptak
Copy link
Author

gliptak commented Sep 15, 2025

@TibixDev please approve workflow run

@fat0troll
Copy link
Collaborator

Approved the workflow run.

@gliptak
Copy link
Author

gliptak commented Sep 16, 2025

👍 the run failed with a 403 (although it was successful at gliptak#1 (comment)

I added https://github.com/TibixDev/winboat/pull/66/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R4
maybe a repo/org level setting update needed (Settings -> Action -> General -> Workflow Permissions and choose read and write permissions?)

@gliptak
Copy link
Author

gliptak commented Sep 20, 2025

@TibixDev please approve workflow run

@fat0troll
Copy link
Collaborator

Approved the run. Also checked the permissions with @TibixDev, it seems like it should work, it has read and write permissions.

@gliptak
Copy link
Author

gliptak commented Sep 21, 2025

thank you @fat0troll looks like below?
image

@TibixDev
Copy link
Owner

image I had to do the checkmark, should be good now?

@gliptak
Copy link
Author

gliptak commented Sep 22, 2025

thank you @TibixDev please approve workflow run

@gliptak
Copy link
Author

gliptak commented Sep 30, 2025

Still 403. I’m not clear how configurations differ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Anything regarding the CI/CD pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants