-
-
Notifications
You must be signed in to change notification settings - Fork 306
Add pull_request trigger to release workflow #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@TibixDev please approve workflow run |
Approved the workflow run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if the pull request build end up somewhere in artifacts so the author of the pull request could use them to test the changes in the provided build by themselves before asking for a merge.
UPD: found it, ignore this comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, oops, I'm blind, found them: https://github.com/TibixDev/winboat/actions/runs/17530023679#artifacts
Could you add a step to the workflow that can post such a link to the pull request itself?
thank you @fat0troll could be modeled after https://github.com/open-turo/actions-go/blob/f1747e80b0dccc25f57c632099397a4ff522415d/prerelease/action.yaml#L186-L198 happy to work this as a followup PR |
7b4475f
to
5374706
Compare
@fat0troll updated with link posting |
@TibixDev please approve workflow run |
Approved the workflow run. |
👍 the run failed with a 403 (although it was successful at gliptak#1 (comment) I added https://github.com/TibixDev/winboat/pull/66/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R4 |
@TibixDev please approve workflow run |
Approved the run. Also checked the permissions with @TibixDev, it seems like it should work, it has read and write permissions. |
thank you @fat0troll looks like below? |
Signed-off-by: Gábor Lipták <[email protected]>
thank you @TibixDev please approve workflow run |
Still 403. I’m not clear how configurations differ |
https://github.com/gliptak/winboat/actions/runs/17529895526?pr=1