Skip to content

Conversation

PhantomDave
Copy link

I Was using this amazing app to do some work, but i had a legacy windows application that needed to connect to a database, we connect to the database using an SSH Tunnel and it was not working because the container was not sharing it' s network with the Linux machine

so i added the possibility to do that,

These are really minor edits, but should be pretty self-explanatory

image

@Copilot Copilot AI review requested due to automatic review settings October 17, 2025 17:13
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds an option to allow the Windows VM container to resolve host.docker.internal to the Docker host gateway, enabling the VM to reach services on the Linux host.

  • Introduces a new install option (addHostDockerInternal) and corresponding UI step.
  • Updates Compose generation to set extra_hosts when enabled.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/types.ts Adds addHostDockerInternal to InstallConfiguration and extra_hosts to ComposeConfig to support injecting host.docker.internal.
src/renderer/views/SetupUI.vue Adds a new wizard step and checkbox to toggle host.docker.internal access; wires the flag into install payload; formatting cleanups.
src/renderer/lib/install.ts Sets services.windows.extra_hosts when addHostDockerInternal is enabled.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like i had prettier enabled, let me know if you want this to be reverted

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting with prettier is good provided it follows the .prettierrc rules - some files have likely missed being formatted.
(Our .prettierrc probably needs some improvements as well in future - but that's a separate discussion)

@Levev
Copy link
Collaborator

Levev commented Oct 19, 2025

WinBoat allows users to edit their compose file directly, and I think this is a great example of why that is. Adding this setting to the winboat config isn't necessary in my opinion.

I'll be closing this PR for now.

@Levev Levev closed this Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants