Update for diesel 2.0 #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riking
reviewed
Feb 27, 2024
| pub fn create_testing_output<DB: TypeMetadata>() -> Output<'static, Vec<u8>, DB> { | ||
| use std::mem; | ||
| #[cfg_attr(feature = "clippy", allow(invalid_ref))] | ||
| Output::new(Vec::new(), unsafe { mem::uninitialized() }) |
There was a problem hiding this comment.
This line causes https://asan.saethlin.dev/ub?crate=diesel_geometry&version=1.4.0
There was a problem hiding this comment.
This is not a fix, I just stripped out some tests because they were causing issues for me when I slapped this port together
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes changes in order to support Diesel 2.0.
Had to get rid of a couple test cases, because I couldn't figure out how the new
Output::newworks, but it should still work just fine.