forked from electronicarts/CnC_Generals_Zero_Hour
-
Notifications
You must be signed in to change notification settings - Fork 87
Labels
BugSomething is not working right, typically is user facingSomething is not working right, typically is user facingCriticalSeverity: Minor < Major < Critical < BlockerSeverity: Minor < Major < Critical < Blocker
Milestone
Description
Area(s) with this issue?
No response
Describe the issue
Init_Compact_Log doesn't zero-initialize the os_info
object, and Get_OS_Info
isn't guaranteed to initialize all of the members either. This is causing a startup crash, especially on the VS2022 branch, whenever os_info.Code
happens to pick up non-zero garbage data.
This ticket is to fix that by always initializing the values in Get_OS_Info
, instead.
Will open a PR for this shortly.
Steps to reproduce
- Startup game
- Be unlucky
- Observe crash
- If you have a debugger attached, observe the crash occurring when calling
COMPACTLOG
below.
Attachments
No response
Metadata
Metadata
Assignees
Labels
BugSomething is not working right, typically is user facingSomething is not working right, typically is user facingCriticalSeverity: Minor < Major < Critical < BlockerSeverity: Minor < Major < Critical < Blocker