Stop command triggers twice when pressing and releasing Stop key

[kABUSE1]

The Stop Command Button is coded to trigger when you release "S".

But all units are also hard-coded to stop when you press "S", regardless if they have the Stop Command Button or not. So removing this hotkey won't have any apparent consequence for end-users, as units are still hard-coded to stop.

In 1.04 this results in units units stopping twice. Once when you press S, once when you release it. This only happens with units that have a "STOP" command button. So workers and dozers are not affected by the bug.

It is unclear to me if there are any related issues caused by this. Potentially.
It did cause issues in a custom map that I am currently creating and I don't think users would expect their units to stop twice for a single button press. It gets really obvious when you slowly press-release the hotkey.

Solution:
Remove "S" as hotkey for the stop command button. As this could potenially confuse new players who do not yet know command buttons, you should instead show in help text of command button that hotkey "S" exists.

[xezon]

Good observation. I did notice that they have overlapping mapping, but did not account for it invoking Stop twice. It appears reasonable to remove the key mapping from Stop button.

[xezon]

In TheSuperHackers/GeneralsGamePatch#824 we fixed button behavior of ControlBar.wnd:ButtonCommand14 so it no longer triggers on release, but on press. Interestingly this only applies to Mouse click behavior. Hot key still activates on release, not press.

Removing S key mapping from Stop button will get rid of the double stop, but will also mute the GUI click sound. Not sure if that is ok.

[xezon]

Perhaps hot keys should not trigger on release, but on press. This would solve this issue without removing key mapping from button.

[kABUSE1]

Perhaps hot keys should not trigger on release, but on press. This would solve this issue without removing key mapping from button.

This sounds like the perfect solution that would also make the controls feel slightly more direct.

Should probably be tested with some hotkey-obsessed pro-players to make sure that is doesn't feel weird.

[MTKing4]

Should probably be tested with some hotkey-obsessed pro-players to make sure that is doesn't feel weird.

making it on press will probably shave off a couple of milliseconds of response time, so if nothing, pro players will even appreciate this more.

[ImTimK]

The faster the response time, the better.

Are there any reliability issues when the command is given once?