Duplicate and outdated INIZH.big file is not cleaned up on EA app/origin installs and is loaded

[x64-dev]

Prerequisites

• I have searched for similar issues and confirmed this is not a duplicate

Game Version

• Command & Conquer Generals
• Command & Conquer Generals: Zero Hour
• Other (please specify below)

Bug Description

The game shipped with leftover outdated files (duplicate INIZH.big in Data/INI).

Line 342 in GameEngine.cpp tries to clean this up on startup, but this does not work on the EA app/origin version of the game because the folder is owned by the app and is not writable.

This results in the duplicate INI being loaded, which causes INI CRC not to match in multiplayer games, and can cause a mismatch if you do manage to get into game.

Reproduction Steps

1. Install the game from EA App/Origin
2. Observe two INIZH.big files, one in the root folder and one in Data/INI
3. Run the game, notice that the DeleteFile/cleanup code does not successfully delete it (if you try to manually delete it via explorer, you'll need to give admin approval to do so
4. Try to join a multiplayer game which performs CRC checks, notice the CRC doesn't match, despite a clean game install via EA app
5. If you do manage to get past the CRC check, the game will eventually mismatch

Additional Context

In GeneralsOnline, we now skip this file during loading, but there is probably a better solution for the longer term

[Caball009]

Can you try with my provisional fix for the quickstart issue and see if the crc issue and mismatch persist? I suspect it'll fix the mismatch here as well.

[x64-dev]

This is not related to quickstart. There's a duplicate (and outdated) INIZH.big file in the EA version which the game tries to delete on startup:

	//Kris: Patch 1.01 - November 17, 2003
	//I was unable to resolve the RTPatch method of deleting a shipped file. English, Chinese, and Korean
	//SKU's shipped with two INIZH.big files. One properly in the Run directory and the other in Run\INI\Data.
	//We need to toast the latter in order for the game to patch properly.
	DeleteFile( "Data\\INI\\INIZH.big" );

This works fine on Steam and disc versions. However, the EA app modifies the permissions of the install folder, so the game is unable to write to the directory and cannot delete this file, meaning the game does load it.

[Caball009]

The eventual mismatch sounds like it could have the same root issue.

[xezon]

Skipping loading that thing looks totally reasonable.