Game Crash if the owner of a Civilian Ferry press GO without the needed setup

[DrGoldFish1]

Prerequisites

• I have searched for similar issues and confirmed this is not a duplicate

Game Version

• Command & Conquer Generals
• Command & Conquer Generals: Zero Hour
• Other (please specify below)

Bug Description

So when you place a Civilian ferry and make it so a player owns it but it is not setup at all, and if you then press GO then the game will straight on CRASH.

[0x0] generalszh!RailedTransportAIUpdate::update+0x71 0x19fa8c 0x49b5b1
[0x1] generalszh!GameLogic::update+0x2a1 0x19fa9c 0x716a99
[0x2] generalszh!Win32GameEngine::update+0x9 0x19fad8 0x40fb3a
[0x3] generalszh!GameEngine::execute+0x4a 0x19fae4 0x40e2f3
[0x4] generalszh!GameEngine::init+0x23 0x19faf4 0x412d26
[0x5] generalszh!GameMain+0x26 0x19fb14 0x401bad
[0x6] generalszh!WinMain+0x45d 0x19fb18 0x8a6c22
[0x7] generalszh!WinMainCRTStartup+0x134 0x19fee0 0x76bb7ba9
[0x8] KERNEL32!BaseThreadInitThunk+0x19 0x19ff7c 0x77eac3ab
[0x9] ntdll!__RtlUserThreadStart+0x2b 0x19ff8c 0x77eac32f
[0xa] ntdll!_RtlUserThreadStart+0x1b 0x19ffe4 0x0

Reproduction Steps

1.Place a ferry in the map that you own
2.Press Go without setting the ferry mechanics up

Additional Context

No response

[OccultGuy]

So, it "helps" you get to Worldbuilder faster, where you can fix it :-)

Should check for empty values and give feedback like an info text. wol:chaterrornotoper says "Cannot perform that operation" or similar - would be fitting

[Mauller]

The problem here is that no "Railroad" waypoints are setup for the ferry, so it's accessing on a null pointer within waypoints.

The simple fix here is to check if the target waypoint is valid and return early before attempting to move.