[GEN][ZH] Rest of asm code made VC only

Author: zzambers

Dependencies/Utility/Utility/CppMacros.h

@@ -19,6 +19,11 @@
 // This file contains macros to help upgrade the code for newer cpp standards.
 #pragma once
 
+#include <cassert>
+#define UNIMPLEMENTED_ERROR(msg) do { \
+  assert(("Unimplemented: ", msg, 0)); \
+  } while(0)
+
 #if __cplusplus >= 201703L
 #define NOEXCEPT_17 noexcept
 #else

Generals/Code/GameEngine/Source/Common/System/StackDump.cpp

@@ -28,6 +28,7 @@
 
 #pragma pack(push, 8)
 
+#include <Lib/BaseType.h>
 #include "Common/StackDump.h"
 #include "Common/Debug.h"
 
@@ -76,6 +77,7 @@ void StackDump(void (*callback)(const char*))
 
 	DWORD myeip,myesp,myebp;
 
+#ifdef _MSC_VER
 _asm
 {
 MYEIP1:
@@ -86,6 +88,9 @@ _asm
  mov eax, ebp
  mov dword ptr [myebp] , eax
 }
+#else
+    UNIMPLEMENTED_ERROR("StackDump");
+#endif
 
 
 	MakeStackTrace(myeip,myesp,myebp, 2, callback);
@@ -340,6 +345,7 @@ void FillStackAddresses(void**addresses, unsigned int count, unsigned int skip)
     gsContext.ContextFlags = CONTEXT_FULL;
 
 	DWORD myeip,myesp,myebp;
+#ifdef _MSC_VER
 _asm
 {
 MYEIP2:
@@ -351,6 +357,9 @@ _asm
  mov dword ptr [myebp] , eax
  xor eax,eax
 }
+#else
+    UNIMPLEMENTED_ERROR("FillStackAddresses");
+#endif
 memset(&stack_frame, 0, sizeof(STACKFRAME));
 stack_frame.AddrPC.Mode = AddrModeFlat;
 stack_frame.AddrPC.Offset = myeip;

GeneralsMD/Code/GameEngine/Source/Common/System/StackDump.cpp

@@ -28,6 +28,7 @@
 
 #pragma pack(push, 8)
 
+#include <Lib/BaseType.h>
 #include "Common/StackDump.h"
 #include "Common/Debug.h"
 
@@ -76,6 +77,7 @@ void StackDump(void (*callback)(const char*))
 
 	DWORD myeip,myesp,myebp;
 
+#ifdef _MSC_VER
 _asm
 {
 MYEIP1:
@@ -86,6 +88,9 @@ _asm
  mov eax, ebp
  mov dword ptr [myebp] , eax
 }
+#else
+    UNIMPLEMENTED_ERROR("StackDump");
+#endif
 
 
 	MakeStackTrace(myeip,myesp,myebp, 2, callback);
@@ -340,6 +345,7 @@ void FillStackAddresses(void**addresses, unsigned int count, unsigned int skip)
     gsContext.ContextFlags = CONTEXT_FULL;
 
 	DWORD myeip,myesp,myebp;
+#ifdef _MSC_VER
 _asm
 {
 MYEIP2:
@@ -351,6 +357,9 @@ _asm
  mov dword ptr [myebp] , eax
  xor eax,eax
 }
+#else
+    UNIMPLEMENTED_ERROR("FillStackAddresses");
+#endif
 memset(&stack_frame, 0, sizeof(STACKFRAME));
 stack_frame.AddrPC.Mode = AddrModeFlat;
 stack_frame.AddrPC.Offset = myeip;

GeneralsMD/Code/Libraries/Source/debug/debug_debug.cpp

@@ -31,6 +31,8 @@
 #include <stdio.h>
 #include <string.h>
 #include <new>      // needed for placement new prototype
+#include <Lib/BaseType.h>
+#include <Utility/intrin_compat.h>
 
 // a little dummy variable that makes the linker actually include
 // us...
@@ -270,11 +272,15 @@ bool Debug::SkipNext(void)
   // do not implement this function inline, we do need
   // a valid frame pointer here!
   unsigned help;
+#ifdef _MSC_VER
   _asm 
   {
     mov eax,[ebp+4]   // return address
     mov help,eax
   };
+#else
+    UNIMPLEMEMTED_ERROR("Debug::SkipNext");
+#endif
   curStackFrame=help;
 
   // do we know if to skip the following code?
@@ -386,7 +392,7 @@ bool Debug::AssertDone(void)
           }
           break;
         case IDRETRY:
-          _asm int 0x03
+          __debugbreak();
           break;
         default:
           ((void)0);
@@ -654,7 +660,7 @@ bool Debug::CrashDone(bool die)
             }
             break;
           case IDRETRY:
-            _asm int 0x03
+            __debugbreak();
             break;
           default:
             ((void)0);

GeneralsMD/Code/Libraries/Source/debug/debug_except.cpp

@@ -28,6 +28,7 @@
 //////////////////////////////////////////////////////////////////////////////
 #include "_pch.h"
 #include <commctrl.h>
+#include <Lib/BaseType.h>
 
 DebugExceptionhandler::DebugExceptionhandler(void)
 {
@@ -173,12 +174,16 @@ void DebugExceptionhandler::LogFPURegisters(Debug &dbg, struct _EXCEPTION_POINTE
     double fpVal;
 
     // convert from temporary real (10 byte) to double
+#ifdef _MSC_VER
     _asm
     {
       mov eax,value
       fld tbyte ptr [eax]
       fstp qword ptr [fpVal]
     }
+#else
+    UNIMPLEMENTED_ERROR("LogFPURegisters");
+#endif
 
     dbg << " " << fpVal << "\n";
   }

GeneralsMD/Code/Libraries/Source/debug/debug_stack.cpp

@@ -28,6 +28,7 @@
 //////////////////////////////////////////////////////////////////////////////
 #include "_pch.h"
 #include <imagehlp.h>
+#include <Lib/BaseType.h>
 
 // Definitions to allow run-time linking to the dbghelp.dll functions.
 
@@ -363,6 +364,7 @@ int DebugStackwalk::StackWalk(Signature &sig, struct _CONTEXT *ctx)
   {
     // walk stack back using current call chain
 	  unsigned long reg_eip, reg_ebp, reg_esp;
+#ifdef _MSC_VER
 	  __asm 
     {
     here:
@@ -371,6 +373,9 @@ int DebugStackwalk::StackWalk(Signature &sig, struct _CONTEXT *ctx)
 		  mov	reg_ebp,ebp
 		  mov	reg_esp,esp
 	  };
+#else
+    UNIMPLEMENTED_ERROR("DebugStackwalk::StackWalk");
+#endif
 	  stackFrame.AddrPC.Offset = reg_eip;
 	  stackFrame.AddrStack.Offset = reg_esp;
 	  stackFrame.AddrFrame.Offset = reg_ebp;