some css changes, sidebar border #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TKsM151
commented
Apr 9, 2018
TKsM151
commented
- moved border on body to the sidebar instead for sidebarless pages to not look dumb
- center deal button text
- centered login and signup page forms
|
something for #164 |
tstiegler
suggested changes
Apr 9, 2018
templates/security/login.html.twig
Outdated
| @@ -33,7 +33,8 @@ | |||
| {{- 'login_form.reset_password'|trans -}} | |||
| </a> | |||
| {% endif %} | |||
|
|
|||
| <p>Don't have an account? <a href="">Sign up now.</a> | |||
There was a problem hiding this comment.
Does this need to link to the registration page?
There was a problem hiding this comment.
Also, looks like a missing </p> at the end there.
tstiegler
suggested changes
Apr 9, 2018
templates/security/login.html.twig
Outdated
| @@ -33,7 +33,8 @@ | |||
| {{- 'login_form.reset_password'|trans -}} | |||
| </a> | |||
| {% endif %} | |||
|
|
|||
| <p>Don't have an account? <a href="">Sign up now.</a> | |||
There was a problem hiding this comment.
Also, looks like a missing </p> at the end there.
|
Fixed |
tstiegler
approved these changes
Apr 9, 2018
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.