feat: Extract shell command from backticks#645
Open
Columpio wants to merge 1 commit intoTheR1D:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is done?
A produced command is extracted from markdown backticks in
--shellmodeWhy?
Because LLMs are usually taught to produce markdown output. So, even if you ask gently in a prompt, you get markdown backticks most of the time. You will get it especially often on small models, e.g., when running Ollama.
What I tested
grep -rnI "```")P.S.
Hope other Ollama guys like me will now be happy. Please like this PR if you are.
With this PR I can finally do
DEFAULT_MODEL=ollama/qwen2.5-coder:3b-instruct-q6_K.