Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix in OS_info for windows; CMakeLists.txt - add config option to exclude PCI easily #77

Closed
wants to merge 2 commits into from

Conversation

pavel-a
Copy link

@pavel-a pavel-a commented Sep 6, 2024

  • Mute c++ warning; small optimization in OS_info for windows;
  • CMakeLists.txt - add config option to exclude PCI easily
    • Version increased to 0.6.1

In os_info_windows.cpp, version_name() :

  • VARIANT val should be initialized, VC++ compiler warning on val_destructor because of uninitialized inout param.
  • In WMI query get Capture, not Name. No need to find & resize string.

pavel_a added 2 commits September 6, 2024 21:40
 - VARIANT val should be initialized, VC++ compiler warning on val_destructor() because of uninitialized inout param.
 - In WMI query get Capture, not Name. No need to find & resize string.
@nabijaczleweli
Copy link
Collaborator

nabijaczleweli commented Sep 6, 2024

First patch applied (with minor editorial) as c8da4c2. For the second one, replace the CMake filter with a #if[n]def INFOWARE_... in pci.cpp; compare, say, src/gpu/d3d.cpp:

#ifndef INFOWARE_USE_VULKAN
#ifdef INFOWARE_USE_D3D

and in the example, add the same ifdef/ifndef after the version listing, say "compiled without PCI support" or whatever. Also don't change the version.

@pavel-a
Copy link
Author

pavel-a commented Sep 6, 2024

done partially, sent new

@pavel-a pavel-a closed this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants