Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pretty preference panel #359

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Pretty preference panel #359

wants to merge 4 commits into from

Conversation

ungjinPark
Copy link
Contributor

Re-style the preferences panel.

  1. I propose implementing a fixed bottom area for "Save" and "Cancel" actions to eliminate the need for scrolling to the bottom of the panel.
  2. I suggest increasing the spacing to give more neat feeling to users.

Sample(Light, Dark

image
image

= added 4 commits November 29, 2024 00:06
Update a Korean translation strings
1f448d2 
- **Menu** :
  - "Move to previous monitor" -> "이전 모니터로 옮기기"
  - "Move to next monitor" -> "다음 모니터로 옮기기"
- **Main** :
  - "Version {version} is available" -> {version} 버전을 사용할 수
    있습니다."
  - "More Details" -> "상세 내역 보기"
  - "Download" -> "다운로드"
  - "Close" -> "닫기"
- **About**
  - Under -> "라이선스"
Improve color contrast of the fail/pass icon
7852250 
The contrast mode issue(ThePacielloGroup#355, ThePacielloGroup#356) prompted me to revisit the color contrast of the CCA user interface.

I identified issues with color contrast across various screen theme modes (e.g., Windows Contrast Theme, Dark Mode, Light Mode), particularly with the fail (X mark) and pass (check mark) icons.

To address this, I adjusted the colors to ensure a contrast ratio of at least 4.5:1 in all modes (Light, Dark, and Contrast Mode).
convert some svg(s) to icon text with icomoon
9cc2de2
re-style preference panel
8c2533e 
- Add more wide space between the fieldsets and controls in the preferences panel.

- Add sticky bottom area for saving and canceling without scroll down.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ungjinPark