-
Notifications
You must be signed in to change notification settings - Fork 15.8k
Computer Science (both courses): Improve space complexity content #30463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Computer Science (both courses): Improve space complexity content #30463
Conversation
mao-sz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave more of the content review to Austin but got a couple of nits and word flow suggestions below.
I've only attached the comments to the JS lesson diff but all of the non-code comments apply the same to the Ruby lesson of course.
Co-authored-by: mao-sz <[email protected]>
Co-authored-by: mao-sz <[email protected]>
Co-authored-by: mao-sz <[email protected]>
Co-authored-by: mao-sz <[email protected]>
Co-authored-by: mao-sz <[email protected]>
Co-authored-by: mao-sz <[email protected]>
|
@JoshDevHub in case you missed it in the review main comment, I have the same suggestions for the Ruby version of the lesson. I was just lazy with repeating the comments and suggestions on both files so I only stuck them on the JS one 😅 |
|
@mao-sz Oh I know. I've just been equally lazy about going to fix them myself manually 😅 |
Because
There are a few things that went into this.
The lesson previously included this blog post in the assignment: https://dev.to/mwong068/big-o-space-complexity-lcm
A lot of the explanation of auxiliary space was off-loaded to this post, but it has a couple of inaccuracies:
This blog post has caused repeatedly caused confusion for learners (see the linked issue for one example).
There was a previous section in the lesson that included references to the different approaches one can take when counting space. I decided to merge this into the new auxiliary space section. It covered similar ground, but I also thought the way it was previously worded was a bit unfair to auxiliary space analysis. At least in my experience, it's fairly common to use it, especially when comparing two algorithms that take the same input. This can even be seen when the lesson links to the BigO cheatsheet and multiple sorting algorithms are described as taking up constant space, meaning they're definitely using an auxiliary space lens.
This PR
(All changes are made in both the Ruby and JS versions of the lesson)
#### Other considerationssection and merge it with the new auxiliary space section.Issue
Closes #29254
Additional Information
Pull Request Requirements
location of change: brief description of changeformat, e.g.Intro to HTML and CSS lesson: Fix link textBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection