TASK: Add laugh method (#11)#122
Merged
TheGittyPerson merged 4 commits intoJun 21, 2026
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for opening your first PR on this repository! Make sure you've read our contributing guidelines — it's very important to us.
Key things to remember when contributing to this repo:
- Avoid touching others' code when possible
- Rebase > Merge; When updating your PR branch, always use a rebase and resolve conflicts
- Try to follow PEP 8
- Avoid using AI to code, comments, or issue/PR descriptions
Owner
|
Thanks for the contribution! Will review this tomorrow |
Contributor
Author
|
Thank you sir |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
TheGittyPerson
requested changes
Jun 21, 2026
Comment on lines
+432
to
+435
| "small": "\U0001F642", # 🙂 slightly smiling face | ||
| "smile": "\U0001F60A", # 😊 smiling face, smiling eyes | ||
| "grin": "\U0001F601", # 😁 grinning face with smiling eyes | ||
| "wide": "\U0001F604", # 😄 open mouth with smiling eyes | ||
| "small": "\U0001F642", # dYT, slightly smiling face | ||
| "smile": "\U0001F60A", # dY~S smiling face, smiling eyes | ||
| "grin": "\U0001F601", # dY~? grinning face with smiling eyes | ||
| "wide": "\U0001F604", # dY~, open mouth with smiling eyes |
| """ | ||
| laughing_emojis = { | ||
| "light": "\U0001F606", # 😆 grinning squinting face | ||
| "tears": "\U0001F923", # 🤣 rolling on the floor laughing |
Owner
There was a problem hiding this comment.
You accidentally used the same one as rofl
Contributor
Author
|
Thanks for the review! I've fixed the duplicate emoji issue - each laugh type now has a unique emoji. Let me know if there's anything else to change. |
This appeared to be some encoding issue Signed-off-by: Morpheus <167074500+thegittyperson@users.noreply.github.com>
TheGittyPerson
approved these changes
Jun 21, 2026
TheGittyPerson
left a comment
TheGittyPerson
left a comment
Owner
There was a problem hiding this comment.
Pushed a commit to fix an unintentional change. Yay we can merge now :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new laugh method to the Person class.
Features: