Add Traveling Salesman Problem Algorithms And Tests #12820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
graphs/traveling_salesman_problem.py
Outdated
| # Find the nearest city to the current location that has not been visited. | ||
| next_city = min( | ||
| ((city, cost) for city, cost in enumerate(graph[current]) if not visited[city] and city != current), | ||
| key=lambda x: x[1], |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: x
There was a problem hiding this comment.
OK! Now I have solved this problem. I replaced the x with 'cost'.
graphs/traveling_salesman_problem.py
Outdated
| return total_cost | ||
|
|
||
|
|
||
| def test_tsp_example(): |
There was a problem hiding this comment.
Please provide return type hint for the function: test_tsp_example. If the function does not return a value, please provide the type hint as: def function() -> None:
There was a problem hiding this comment.
OK! Now I have solved this problem. I added '-> None:' at the end of each function that does not return a parameter.
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
require descriptive names
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…thon into add-tsp-problem
for more information, see https://pre-commit.ci
…thon into add-tsp-problem
for more information, see https://pre-commit.ci
…thon into add-tsp-problem
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
I solved the Open Issue #12128: Add TSP problem in Graph Data Structure.
This pull request implements the Traveling Salesman Problem (TSP) algorithms in the
graphsmodule and tests in thegraphs/testsmodule.tsp_brute_force,tsp_dp, andtsp_greedyfunctions ingraphs/traveling_salesman_problem.py.graphs/tests/test_traveling_salesman_problem.py.Checklist: