Skip to content

testing: improve SortStackTest #6422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alxkm
Copy link
Contributor

@alxkm alxkm commented Jul 20, 2025

This PR enhances the test coverage for the SortStack.sortStack() method by introducing a variety of meaningful and edge case scenarios. The following test cases were added:

Edge Orderings:

  • testSortReverseSortedStack – fully reversed input
  • testSortTwoElements – minimal stack with two unsorted values
  • testSortTwoElementsAlreadySorted – minimal stack with sorted values

Duplicates & Uniform Values:

  • testSortWithAllSameElements – all elements are identical
  • testSortWithManyDuplicates – mixed duplicates across several values

Negative and Boundary Values:

  • testSortWithNegativeNumbers – mix of negative and positive integers
  • testSortWithAllNegativeNumbers – only negative integers
  • testSortWithZero – includes zero
  • testSortStackWithMinAndMaxValues – tests with Integer.MIN_VALUE and Integer.MAX_VALUE

General Robustness:

  • testSortLargerStack – stack with 10 varied elements
  • testOriginalStackIsModified – asserts that the original stack reference is sorted in-place
  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.86%. Comparing base (31bf130) to head (c094ea8).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6422   +/-   ##
=========================================
  Coverage     74.86%   74.86%           
- Complexity     5482     5483    +1     
=========================================
  Files           682      682           
  Lines         19012    19012           
  Branches       3670     3670           
=========================================
+ Hits          14233    14234    +1     
  Misses         4224     4224           
+ Partials        555      554    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants