Skip to content

Fix IFCLoader bundling on modern Node#200

Open
darshan-Jahagirdar wants to merge 1 commit into
ThatOpen:mainfrom
darshan-Jahagirdar:codex/fix-ifcloader-bundling
Open

Fix IFCLoader bundling on modern Node#200
darshan-Jahagirdar wants to merge 1 commit into
ThatOpen:mainfrom
darshan-Jahagirdar:codex/fix-ifcloader-bundling

Conversation

@darshan-Jahagirdar
Copy link
Copy Markdown

Fixes #120.

The current build fails before bundling with modern Node because rollup-plugin-typescript2@0.30.0 depends on an old nested tslib and tries to load tslib/package.json, which is blocked by the package exports map.

This updates rollup-plugin-typescript2 to 0.36.0, which uses a compatible tslib and lets the existing Rollup build complete without changing loader source code.

Verification:

  • npm ci --ignore-scripts
  • npm run build from the repo root: passed, including web-ifc-three and example
  • git diff --check

Note: npm test -- --runInBand still fails on existing Jest/TypeScript transform configuration before running tests; it is unrelated to this bundling fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IFCLoader bundling

1 participant