Fix IFCLoader bundling on modern Node#200
Open
darshan-Jahagirdar wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #120.
The current build fails before bundling with modern Node because
rollup-plugin-typescript2@0.30.0depends on an old nestedtsliband tries to loadtslib/package.json, which is blocked by the package exports map.This updates
rollup-plugin-typescript2to0.36.0, which uses a compatibletsliband lets the existing Rollup build complete without changing loader source code.Verification:
npm ci --ignore-scriptsnpm run buildfrom the repo root: passed, includingweb-ifc-threeandexamplegit diff --checkNote:
npm test -- --runInBandstill fails on existing Jest/TypeScript transform configuration before running tests; it is unrelated to this bundling fix.