Skip to content

130 webworker CreateIfcGuidToExpressIdMapping support#198

Open
longbiaochen wants to merge 1 commit into
ThatOpen:mainfrom
longbiaochen:feat/130-webworker-guid-mapping
Open

130 webworker CreateIfcGuidToExpressIdMapping support#198
longbiaochen wants to merge 1 commit into
ThatOpen:mainfrom
longbiaochen:feat/130-webworker-guid-mapping

Conversation

@longbiaochen
Copy link
Copy Markdown

Summary

  • Added CreateIfcGuidToExpressIdMapping to the web-ifc worker API surface.
  • Wired the action through WorkerActions, WebIfcHandler, and WebIfcWorker.
  • Added typing to WebIfcAPI so ifcLoader.ifcManager.ifcAPI.CreateIfcGuidToExpressIdMapping(...) works in both direct and worker mode.

Validation

  • npx tsc -p config/tsconfig.json --noEmit
  • npm run build ❌ (environment issue: rollup-plugin-typescript2 fails on tslib package.json exports in current workspace)

Fixes #130

@longbiaochen
Copy link
Copy Markdown
Author

@agviegas quick ping on PR #198: this adds WebWorker support for issue #130 and keeps changes under 50 lines. If you can give a quick pass/any blocker notes, I can address immediately.

@longbiaochen
Copy link
Copy Markdown
Author

Final ping @agviegas: I only need a 1-line first-pass status (accept / needs adjustment / please close). If needed I can change in a single follow-up commit within 30 min.

@agviegas
Copy link
Copy Markdown
Collaborator

Hi @longbiaochen

We have officially released the new library components on September 20 2023. This library substitutes web-ifc-three and web-ifc-viewer. Both WIV and WIT will remain up, but they will be deprecated and won't be maintained any longer. You are free to fork this if you want to maintain it yourself. You can find the new docs here.

All our efforts are going towards components now. The API is very similar, so I strongly suggest you make the leap and start using it. If you still face this issue with it, you can open an issue there and we'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unable to invoke CreateIfcGuidToExpressIdMapping when using WebWorker

2 participants