Skip to content

Conversation

eliegoudout
Copy link
Collaborator

Before, we'd get the following upon using faiss features on Windows (without the monkeypatch):

OMP: Error #15: Initializing libomp140.x86_64.dll, but found libiomp5md.dll already initialized.
OMP: Hint This means that multiple copies of the OpenMP runtime have been linked into the program. That is dangerous, since it can degrade performance or cause incorrect results. The best thing to do is to ensure that only a single OpenMP runtime is linked into the process, e.g. by avoiding static linking of the OpenMP runtime in any library. As an unsafe, unsupported, undocumented workaround you can set the environment variable KMP_DUPLICATE_LIB_OK=TRUE to allow the program to continue to execute, but that may cause crashes or silently produce incorrect results. For more information, please see http://openmp.llvm.org/

It is now fixed thanks to faiss-cpu>=1.12 explicitly adding OpenBLAS submodule.

@eliegoudout eliegoudout force-pushed the 16/faiss-cpu-1.12.0 branch 6 times, most recently from e999fc0 to 2b0cf57 Compare August 13, 2025 20:43
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (fefb2e0) to head (77cb540).
⚠️ Report is 8 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop       #20   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           69        69           
  Lines         3722      3728    +6     
=========================================
+ Hits          3722      3728    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eliegoudout eliegoudout force-pushed the 16/faiss-cpu-1.12.0 branch 7 times, most recently from 1e8913e to 9af144f Compare August 13, 2025 21:53
@eliegoudout eliegoudout marked this pull request as ready for review August 13, 2025 22:00
@ego-thales ego-thales changed the title dev: faiss-cpu>=1.12.0 fixes OpenMP duplicate issue dev: Fix Windows OpenMP duplicate issue + tutorials torch.hub rate limit issues (monkeypatch) Aug 13, 2025
@ego-thales ego-thales changed the title dev: Fix Windows OpenMP duplicate issue + tutorials torch.hub rate limit issues (monkeypatch) fix: Windows OpenMP duplicate issue + tutorials torch.hub rate limit issues (monkeypatch) Aug 13, 2025
@ego-thales ego-thales merged commit 0a23840 into ThalesGroup:develop Aug 13, 2025
1 check passed
@eliegoudout eliegoudout deleted the 16/faiss-cpu-1.12.0 branch August 13, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants