Open
Conversation
pjonsson
reviewed
Feb 25, 2026
pjonsson
reviewed
Feb 25, 2026
pjonsson
reviewed
Feb 25, 2026
| /*eslint-env node*/ | ||
| /*eslint no-sync: 0*/ | ||
| /* eslint-disable @typescript-eslint/no-require-imports */ | ||
|
|
Contributor
There was a problem hiding this comment.
ESLint 9 automatically warns for --report-unused-disable-directives, so that parameter could possibly be dropped from the lint function below.
pjonsson
reviewed
Feb 25, 2026
| { | ||
| name: "terriajs/include-files", | ||
| files: [ | ||
| "**/*.jsx", |
Contributor
There was a problem hiding this comment.
I think I measured runtime when I did the ESLint 9 config, and "**/*.{jsx,tsx,js,ts,cjs,mjs}" (no spaces after the commas) is faster than a list of multiple globs.
pjonsson
reviewed
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Migrate to eslint flat config as eslint removed support for legacy configs in v10.
Test me
How should reviewers test this? (Hint: If you want to provide a test catalog item, create a Gist of its catalog JSON, add its url and your branch name to this url:
http://ci.terria.io/<branch name>/#clean&<raw url of your gist>, and then paste that in the body of this PR)Checklist
doc/.