Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for new Terasology serialization system (engine PR 3535) #33

Closed
Cervator opened this issue Sep 5, 2018 · 2 comments · Fixed by #48
Closed

Fixes for new Terasology serialization system (engine PR 3535) #33

Cervator opened this issue Sep 5, 2018 · 2 comments · Fixed by #48

Comments

@Cervator
Copy link
Member

Cervator commented Sep 5, 2018 •
edited by eviltak
Loading

Merging MovingBlocks/Terasology#3456 causes this module to no longer compile

Current module users include TutorialDynamicCities and MedievalCities, both culture providers needed to be able to use DC.

Sending this @eviltak's way as the author of the engine PR and/or to @Naman-sopho as maybe interested from recent work here :-)

For previous reverted fixes (may be less relevant with later changes to the serialization system), see bce0354.
@Cervator Cervator mentioned this issue Sep 5, 2018
Merged
10 tasks
@Cervator
Copy link
Member Author

Note: This is now tied to MovingBlocks/Terasology#3490 instead - see it for details

@eviltak
Copy link
Member

eviltak commented Oct 30, 2018

Now tracked by MovingBlocks/Terasology#3535.

@eviltak eviltak changed the title Adjustments needed for engine PR 3456 Fixes for new Terasology serialization system (engine PR 3535) Oct 30, 2018
@eviltak eviltak mentioned this issue Dec 19, 2018
Merged
11 tasks
@eviltak eviltak mentioned this issue Jul 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove DynParcelTypeHandler eviltak/DynamicCities
2 participants
@Cervator @eviltak