Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in MovingBlocks/Terasology#3535 have made the existing type handlers of
PlayerAction
and its implementations obsolete. This PR removes those TypeHandlers since their functionality is already present in the new serialization system.This does lead to a slight change in format of their serialization, however. The type of all PlayerActions must be specified in a
class
field, not atype
field as was before. Moreover, when being used outside the Dialogs module, the type specified must contain the Dialogs module name in its URI.As an example, a usage of
ChangeDialogAction
in the LightAndShadow module would change fromto
A
PlayerActionSerializationTest
test class has also been added containing tests asserting the format in which PlayerActions are serialized.Should only be merged after the engine PR has been merged.
Resolves #8.