Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for new Terasology serialization system (engine PR 3535) #8

Closed
Cervator opened this issue Sep 5, 2018 · 2 comments · Fixed by #11
Closed

Fixes for new Terasology serialization system (engine PR 3535) #8

Cervator opened this issue Sep 5, 2018 · 2 comments · Fixed by #11

Comments

@Cervator
Copy link
Member

Cervator commented Sep 5, 2018

The new serialization system introduced by MovingBlocks/Terasology#3535 (tracking branch MovingBlocks/newSerialization) causes this module to no longer compile. Only 4 classes (the TypeHandler implementations in org.terasology.dialogs.action) are affected and the changes seem fairly straight forward - although I'm not sure if any issues will result after.

Current users of Dialogs include LightAndShadow (the NPC on the spawn platform) and TutorialDynamicCities (vaguely recall a market screen you can trigger from an NPC in a specific building?). Both naturally thus won't work either, but could be useful for testing when also fixed.

Sending this @eviltak's way as the author of the engine PR and/or to @dacharya64 / @Naman-sopho in case either of them have a chance to check it out :-)

For previous reverted fixes (may be less relevant with later changes to the serialization system), see 3b5804e.

@Cervator Cervator changed the title Adjustments needed for engine PR Adjustments needed for engine PR 3456 Sep 5, 2018
@Cervator
Copy link
Member Author

Note: This is now tied to MovingBlocks/Terasology#3490 instead - see it for details

@eviltak eviltak changed the title Adjustments needed for engine PR 3456 Adjustments needed for engine PR 3535 Oct 30, 2018
@eviltak
Copy link
Member

eviltak commented Oct 30, 2018

Now tracked by PR MovingBlocks/Terasology#3535.

@eviltak eviltak changed the title Adjustments needed for engine PR 3535 Fixes for new Terasology serialization system (engine PR 3535) Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants