Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qa/checkstyle #47

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Qa/checkstyle #47

wants to merge 5 commits into from

Conversation

soloturn
Copy link
Contributor

No description provided.

* See the License for the specific language governing permissions and
* limitations under the License.
*/
// Copyright 2021 The Terasology Foundation

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2014 -> 2021? What has changed? If nothing else in the file has changed then I might just leave the 2014 date in there.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the case for most of the changes in this pull request.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's stick with our current practice of updating to the current year for now so we keep consistency
as mentioned on Discord, we can discuss our copyright practices in the next reviver meeting

@soloturn please update all copyright headers in hear to the current year 2023

Copy link
Contributor Author

@soloturn soloturn Dec 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdrueckert i looked it up this time, and not updating would be the safe option:
https://techwhirl.com/updating-copyright-notices/

“the year date [in the copyright notice] is more than one year later than the year in which publication first occurred, the work is considered to have been published without any notice….”

that would mean, if somebody using code older than a year, it would have some default copyright and any committer could sue the person using it. of course one can argue that in git one sees that it was there before and had a different copyright. but for binary downloads? of course nobody of the persons committing here is a copyright troll. but why play with the fire if not necessary. @jdrueckert. i do agree thus with @BenjaminAmos and reverted all to the original. but feel free to ping here in case you really discussed it in a reviewer meeting.

soloturn

This comment was marked as duplicate.

soloturn

This comment was marked as duplicate.

@soloturn soloturn force-pushed the qa/checkstyle branch 2 times, most recently from 4d18100 to 6deb5ca Compare December 17, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants