docs: Add documentation for resolving XFS filesystem requirement on non-xfs root#247
docs: Add documentation for resolving XFS filesystem requirement on non-xfs root#247Dafeigy wants to merge 4 commits into
Conversation
|
#253 also encounter this. I think it may be better written in the guide rather than the |
|
/cubebot review |
|
Claude finished @fslongjin's task in 56s —— View job Review Checklist
Code Review:
|
|
Hi @Dafeigy, Thanks for the PR! The DCO (Developer Certificate of Origin) check is failing. You need to add a You can fix this by amending your commit: git commit --amend --signoff
git push --forceThis will append a |
Signed-off-by: Dafeigy <1070642765@qq.com>
663b097 to
88b13fe
Compare
Done. Thanks for reply~ |
|
Hi @Dafeigy Can you fix the issues mentioned in the cubebot review? |
Signed-off-by: Dafeigy <1070642765@qq.com>
|
Hi @kinwin-ustc Yes, I make some changes to the instructions following the suggestions given by Cubebot. |
…docs/self-build-deploy
|
/cubebot review |
|
Claude finished @kinwin-ustc's task in 45s —— View job Review Checklist
Code Review:
|
| Suggestion | Status |
|---|---|
Add xfsprogs install step |
✅ Done (lines 134-137 in English, 130-135 in Chinese) |
Remove fallocate alternative |
✅ Done — sparse-only approach used |
Guard against duplicate /etc/fstab entries |
✅ Done — grep -q ... || echo ... pattern |
Move loop file from / to a standard path |
✅ Done — now at /var/lib/cube-sandbox/xfs-loopfile |
| Align EN and ZH note wording | ✅ Better aligned — both mention sparse file support |
Remaining Issues
1. RHEL/CentOS install command is broken — both English (line 137) and Chinese (line 134)
# sudo yum update && install xfsprogs -yThe install command is missing yum (and sudo for the second command). This would fail if uncommented. Should be:
# sudo yum update && sudo yum install xfsprogs -y2. Chinese doc is missing the "FileSystem: XFS" prerequisite — docs/zh/guide/self-build-deploy.md
The English doc correctly adds | FileSystem | XFS | to the prerequisites table (line 30), but the Chinese doc does not have a corresponding entry. This should be added for consistency.
3. Minor typo in Chinese note — docs/zh/guide/self-build-deploy.md line 151
seed should be seek:
你可以自行通过 `seek` 和 `count` 的调整以适配当前的硬件条件。
Additional Observations
- Verification step is clear:
df -T /data/cubeletwith expected output is present in both docs. - Sparse file approach is correct:
bs=1G count=0 seek=20creates a truly sparse file without pre-allocating blocks. - DCO is now passing: The DCO check issue from the previous review has been resolved.
Summary
The PR is in good shape and addresses a real user pain point (issue #245). The three issues above are small fixes — once addressed, this is ready to merge.
Signed-off-by: Dafeigy <1070642765@qq.com>
This PR adds documentation to help users who encounter the following error during the Cube Sandbox one-click installation:
related to #245 .
Problem
Many users (especially those on Ubuntu dual-boot systems) have their root filesystem formatted as
ext4. The one-click installer requires/data/cubeletto reside on an XFS filesystem, but repartitioning a live system is risky and often not possible.Solution
The added guide provides a non-destructive workaround using a loopback file:
/data/cubelet./etc/fstab.This approach works without altering existing partitions and is safe for dual-boot environments.
Testing
df -T /data/cubeletreportsxfs, and the Cube Sandbox installer proceeds without errors.Notes
Please review and merge if appropriate. Thank you!