Fix do_rembg flag being ignored in run_views_to_3d
#13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ary background removal - Fix bug where `remove_background()` was called even when `do_rembg=False` in `run_views_to_3d`. - This was due to `run_segmentation()` defaulting to `do_rembg=True` and not receiving the explicit flag. - Now passes `do_rembg=do_rembg` to ensure correct behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in
run_views_to_3dwhere thedo_rembg=Falsesetting was being ignored, leading to unnecessary background removal.Root Cause
The issue was caused by
run_segmentation()defaulting todo_rembg=Trueand not being explicitly passed thedo_rembgargument fromrun_views_to_3d.Fix
The
do_rembgparameter is now explicitly passed: