fix(time-picker): 验证输入的时间不为被禁止的 #2266
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closed #5939
16 tasks
Wesley-0808
reviewed
Sep 1, 2025
js/time-picker/utils.ts
Outdated
| export function validateInputValue( | ||
| value: string, | ||
| format: string, | ||
| disableTime?: (...params: any) => any |
There was a problem hiding this comment.
返回值不应该定义为any？
这个方法有具体的返回类型吧
There was a problem hiding this comment.
下面这种写法可以吗，可以的话我commit一下
export function validateInputValue(
value: string,
format: string,
disableTime?: (...params: any) => { [key in EPickerCols]?: number[]; } | null
) { ...
Wesley-0808
reviewed
Sep 7, 2025
js/time-picker/utils.ts
Outdated
| s: number, | ||
| ms: number, | ||
| context: { partial: 'start' | 'end' }, | ||
| ) => Partial<{ hour: Array<number>; minute: Array<number>; second: Array<number> }> |
There was a problem hiding this comment.
这个函数是timePicker和timeRangePicker共用的，所以需要考虑到毫秒的情况
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
fix #5939
💡 需求背景和解决方案
📝 更新日志
fix(time-picker): 在validateInputValue中加入对禁止时间的判定
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单