fix(android): should properly update styles for text color #4412
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoomchan-cxj
requested review from
wwwcg and
zealotchen0
and removed request for
siguangli and
zoomchan-cxj
|
Pay attention 🛎️ !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is here https://github.com/situ2001/Hippy/blob/972f612f57599be5e8f894554ad5dd39bdb3e204/examples/hippy-react-demo/src/components/RerenderBug/index.jsx#L30-L61
In short, this fix can be broken into two parts:
COLOR.BLACK, when style of color from JS side isundefined.undefinedwhen@hippy/reactabout to update the node,@hippy/reactwill not notify native side to update the style.Before
Screen_Recording_20250912_184351_Hippy.Demo.mp4
After fix
Screen_Recording_20250912_184427_Hippy.Demo.mp4