-
Notifications
You must be signed in to change notification settings - Fork 0
💅 Design polish improvements #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FAQ button clickable area reduced by padding relocation
Medium Severity
Moving
px-8from the button to the container reduces the clickable target area. Previously the button included the horizontal padding as part of its clickable region. Now the padding sits outside the button, so users clicking/tapping in the 2rem padding zones on either side won't trigger the accordion. This is problematic because the.faq-item:hoverstyles (scale, border accent) visually suggest the entire area is interactive, creating an inconsistency between hover feedback and actual click behavior.Additional Locations (2)
index.html#L1141-L1145index.html#L1174-L1178There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch! Moved
px-8back to the button elements. The padding is now part of the clickable area, so the full horizontal width of the FAQ item is interactive. This makes the visual hover feedback (scale + border) align with the actual touch target.