send projection information to the readSnapshot middleware #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcharbonnier
commented
Aug 1, 2018
| @@ -82,6 +82,9 @@ Backend.prototype._shimDocAction = function() { | |||
| this.use(this.MIDDLEWARE_ACTIONS.readSnapshots, function(request, callback) { | |||
| async.each(request.snapshots, function(snapshot, eachCb) { | |||
| var docRequest = {collection: request.collection, id: snapshot.id, snapshot: snapshot}; | |||
| if(request.projection) { | |||
There was a problem hiding this comment.
sharedb-access expect an index property and use the deprecated doc middleware
Pull Request Test Coverage Report for Build 98
💛 - Coveralls |
curran
suggested changes
Nov 22, 2018
There was a problem hiding this comment.
It's not totally clear what problem this solves. The description in the issue mentions "correctly setup authorizations", but how does this change solve that problem?
Adding tests to cover the changes here would be good to do.
CI is currently failing on this PR.
| @@ -1,7 +1,7 @@ | |||
| var json0 = require('ot-json0').type; | |||
|
|
|||
| exports.projectSnapshot = projectSnapshot; | |||
| exports.projectSnapshots = projectSnapshots; | |||
| exports.projectsSnapshots = projectsSnapshots; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix share#234