Basic custom Ogg Opus comment tag write support #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes let PyOgg users add custom comment tags to the generated stream, as opposed to the current behavior of hardcoding no comment tags on all cases, which can come in handy for stream identification requirements. While at it, I've tweaked the vendor string from `ENCODER=PyOgg` to `PyOgg <VERSION>`, where `<VERSION>` is the value of the `__version__` variable at `__init__.py`. The rationale for this change is that this brings the vendor string format more in line with the conventions used by libopus and other encoders (such as FFmpeg and libavcodec), while also being more useful to track the precise encoder code used to generate the stream thanks to the addition of the version number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes let PyOgg users add custom comment tags to the generated stream, as opposed to the current behavior of hardcoding no comment tags on all cases, which can come in handy for stream identification requirements.
While at it, I've tweaked the vendor string from
ENCODER=PyOggtoPyOgg <VERSION>, where<VERSION>is the value of the__version__variable at__init__.py. The rationale for this change is that this brings the vendor string format more in line with the conventions used by libopus and other encoders (such as FFmpeg and libavcodec), while also being more useful to track the precise encoder code used to generate the stream thanks to the addition of the version number.