Test Launch Configuration #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luca-byte
reviewed
Dec 4, 2024
There was a problem hiding this comment.
Great job 💯 !!
Also in this case I have not delved into the PR, just some comments on the top of my head:
- At the moment the smaller launch files are not working, since they do not generate YAML files. Were the test passing? In any case as for now we should only use the main launch file. I noticed later of the problem
- The tests seem reasonable, keep in mind that the communication node may crash in an environment without the cansocket (like probably GH Actions).
Implement tests on nodes and launch configuration to ensure nodes start correctly and do not crash.
Implement tests on nodes and launch configuration to ensure nodes start correctly and do not crash.
Implement tests on nodes and launch configuration to ensure nodes start correctly and do not crash.
Implement tests on nodes and launch configuration to ensure nodes start correctly and do not crash.
Yusuf-Serdar
force-pushed
the
57-test-launch-configuration
branch
from
37f06f8 to
8677936
Compare
Delete reseq core launch, digital twin launch, and sensors launch.
Yusuf-Serdar
force-pushed
the
57-test-launch-configuration
branch
from
e8eefed to
009d4ad
Compare
Handle the communication, realsense, and rplidar nodes that are expected to fail for various reasons.
Yusuf-Serdar
force-pushed
the
57-test-launch-configuration
branch
from
009d4ad to
7615785
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #57