Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Dynamixel library #6

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Updated Dynamixel library #6

wants to merge 3 commits into from

Conversation

QuaZaaR2209
Copy link

Updated the Dynamixel library to work with the ESP32 infrastructure, not tested on hardware

Updated the Dynamixel library to work with the ESP32 infrastructure, not tested on hardware
Copy link
Member

@luca-byte luca-byte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. In case of positive tests it can be merged.

The following lines however generate errors, so this test file is not complete

Comment on lines +4 to +6
// TEST SOLUZIONE
//Il pinout dice che il Serial1 TX è il pin numero 4, mentre il pin

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment seems incomplete. Moreover it would be preferable to have english comments in the codebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants