feat : editor 구현 #74
Merged
feat : editor 구현 #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5ewon
approved these changes
Mar 15, 2024
utils/index.ts
Outdated
| `</details><details open class="${details}"><summary class="${summary}">$1</summary>`, | ||
| ) | ||
| .replace(/<빙글빙글>([\s\S]*?)<\/빙글빙글>/gi, "<div class='spin'>$1</div>") | ||
| .replace(/<삐슝빠슝>([\s\S]*?)<\/삐슝빠슝>/gi, "<div class='shake'>$1</div>") | ||
| .replace(/<링크 문서=\{(.*?)\}>(.*?)<\/링크>/g, '<a href="/docs/$1">$2</a>') |
There was a problem hiding this comment.
현재 global.css에서 a태그에 text-decoration속성이 none로 지정된 상태입니다. 이렇게되면 링크태그가 적용된 단어와 그렇지 않은 단어를 구분하기 쉽지 않아 유저 입장에서 혼란을 줄 수 있을 것 같습니다. 글자색을 파란색으로 바꿔주는건 어떨까요?
There was a problem hiding this comment.
좋은것같습니다 ! 잘캐치해주셔서 감사합니다 !!
components/Editor/index.tsx
Outdated
| className={styles.wikiBoxHeader[String(isExampleOpen)]} | ||
| > | ||
| <span className={styles.wikiTitle}>부마위키 문법 예제 보기</span> | ||
| <ArrowIcon direction="down" fill="white" width={16} height={16} viewBox="0 0 26 30" /> |
There was a problem hiding this comment.
열려있을때와 닫혀있을때 화살표 방향을 다르게 하면 좀 더 명시적일 것 같은데 투머치일까요..?
There was a problem hiding this comment.
아뇨 원래 구현해두었어야했는데 깜빡했네요 감사합니다!
There was a problem hiding this comment.
입력한 문서 제목이 preview box에서는 보여지지 않는건가요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#34
What
에디터를 구현했습니다.
How
ScreenShot