Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependency): vanilla extract로 의존성 변경 #6

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

Ubinquitous
Copy link
Member

Issue Number

.

What

styleX가 sc를 쓰던 기존 개발자들이 사용하기에 비록 거부감이 있다고 느꼈습니다.

Why

.

How

.

ScreenShot

.

@Ubinquitous Ubinquitous added the chore 자잘한 변경 label Mar 3, 2024
@Ubinquitous Ubinquitous requested review from 5ewon and jyh071116 March 3, 2024 23:51
@Ubinquitous Ubinquitous self-assigned this Mar 3, 2024
Copy link
Member

@jyh071116 jyh071116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿 수고하셨습니다

app/page.tsx Outdated
import Image from "next/image";
import styles from "./page.module.css";
import React from "react";
import { container } from "./asd.css";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.css.ts 파일에 여러 style들이 있으면

import * as styles from "./asd.css";

이런 식으로 사용하는것이 좋을 것 같습니다

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 예제로 적어둔걸 커밋해버렸네요 !!!
다시 지워놓겠습니다 😀
앞으로의 스타일링은 @jyh071116 님이 말씀해주신 대로 진행하면 좋을 것 같습니다!

Copy link
Member

@5ewon 5ewon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다. 😁😁

@Ubinquitous Ubinquitous merged commit 114031d into main Mar 4, 2024
Ubinquitous pushed a commit that referenced this pull request Mar 5, 2024
@Ubinquitous Ubinquitous deleted the feat/stylesheet-change branch November 15, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore 자잘한 변경
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants