refactor : history 페이지 #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5ewon
approved these changes
Apr 16, 2024
| <h1 className={styles.historyId}>#{history.index}</h1> | ||
| <span className={styles.createdAt}> | ||
| <time className={styles.createdAt}> |
There was a problem hiding this comment.
리뷰에 달만한 내용은 아니지만, 이런게 있는지 오늘 처음 알았습니다. 신기하네요
There was a problem hiding this comment.
리뷰에 달아주셔도 좋습니다!!
저도 이번에 SEO를 향상시키는 방법 중, 시멘틱 태그에 관심이 생겨서 여러가지 태그들을 찾아보았는데,
저희가 흔히 알고 있는 section, article 뿐만 아니라 figure, figcaption, time 등등
여러가지 시멘틱 태그가 있다는 것을 알게 되었습니다!
앞으로도 SEO 향상을 위해서 어떤 부분에서는 실수로 시멘틱 태그를 의도와 맞지 않게 사용하는 한이 있더라도
전체적인 부면을 보면서 시멘틱 태그를 사용하는 습관을 들여야겠다고 생각했습니다!
이번 프로젝트에서는 vanilla extract를 사용 하다보니 태그명이 그대로 눈에 들어와서 시멘틱 태그를 적용하고 나니
확실히 훨씬 각 엘리먼트들이 어떤 정보를 나타내는 지도 더욱 상세히 알 수 있었습니다!!
| return generateOpenGraph({ | ||
| title: `역사#${decodeURI(title)}`, | ||
| description: `${decodeURI(title)} 문서의 역사입니다.`, | ||
| title: `역사#${decodedTitle}`, |
There was a problem hiding this comment.
어차피 같은 데이터 사용할건데 두번 요청할 필요 없죠. 좋습니다~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
history 페이지를 리팩터링했습니다.
How