Fix static code analysis warnings in Visual Studio 2019 #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the three warnings below. This fixes Issue Taywee#88 (noexcept). Not sure if the signed/unsigned char fix is ok for platforms other than Windows. Utilities\DxFileUtility\DxFileUtility\args.hxx (232, 0) Utilities\DxFileUtility\DxFileUtility\args.hxx(232,0): Warning C6330: 'char' passed as _Param_(1) when 'unsigned char' is required in call to 'isspace'. Utilities\DxFileUtility\DxFileUtility\args.hxx (466, 0) Utilities\DxFileUtility\DxFileUtility\args.hxx(466,0): Warning C26439: This kind of function may not throw. Declare it 'noexcept' (f.6). Utilities\DxFileUtility\DxFileUtility\args.hxx (2021, 0) Utilities\DxFileUtility\DxFileUtility\args.hxx(2021,0): Warning C6330: 'char' passed as _Param_(1) when 'unsigned char' is required in call to 'isspace'.
|
Thank you for the PR. I'm not a fan of the unsigned char in the for loop. I don't think it will cause any platform problems and should perform fine, but it is something that sticks out as odd without a comment explaining the case, and might unwittingly be changed back by some future cleanup. I'll pull the PR and add a comment (and maybe also change the loop variable to an |
|
Sounds good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the three warnings below. This fixes Issue #88 (noexcept). Not sure if the signed/unsigned char fix is ok for platforms other than Windows.
Utilities\DxFileUtility\DxFileUtility\args.hxx (232, 0)
Utilities\DxFileUtility\DxFileUtility\args.hxx(232,0): Warning C6330: 'char' passed as Param(1) when 'unsigned char' is required in call to 'isspace'.
Utilities\DxFileUtility\DxFileUtility\args.hxx (466, 0)
Utilities\DxFileUtility\DxFileUtility\args.hxx(466,0): Warning C26439: This kind of function may not throw. Declare it 'noexcept' (f.6).
Utilities\DxFileUtility\DxFileUtility\args.hxx (2021, 0)
Utilities\DxFileUtility\DxFileUtility\args.hxx(2021,0): Warning C6330: 'char' passed as Param(1) when 'unsigned char' is required in call to 'isspace'.