Merged
Conversation
Owner
|
Yeah, I'm happy with breaking backwards compatibility between minor releases. If it's warranted enough, I'm happy breaking backwards compatibility after a realease, with major version bump. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds bash completion function. Example:
Under the hood, bash script calls
program --complete bash NUMBER_OF_CURRENT_ARGUMENT ARGS. I wanted to avoid rewriting args in bash.To test this you can build examples with cmake and add bash completion for
examples/completion.cxx:I broke HelpChoices API (
std::string->std::vector<std::string>). It wasn't released so I guess it's ok. Choices strings are also used by completion.In theory adding zsh and fish should be relatively easy. I added first argument to
--completewhich could be used for shell specific code.