Export taywee::args #124
Merged
Export taywee::args #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of downstream distribution systems prefer using ports rather than fetching anything during the build. FTXUI depends on args via FetchContent. CMake 3.24 support FIND_PACKAGE_ARGS to allow installed packages to override fetch_content. My problem is that `taywee::args` is only exported when installed, but not directly when used as a subproject. This patch exports `taywee::args` so that the same name can be used in both cases. Bug:ArthurSonzogni/json-tui#32
|
Looks completely reasonable to me. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of downstream distribution systems prefer using ports rather than fetching anything during the build. FTXUI depends on args via FetchContent. CMake 3.24 support FIND_PACKAGE_ARGS to allow installed packages to override fetch_content.
My problem is that
taywee::argsis only exported when installed, but only as "args" when usedas a subproject.
This patch exports
taywee::argsso that the same name can be used in both cases.Bug:ArthurSonzogni/json-tui#32