Relax regex parsing of csrf_token #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer works because instagram changed schema.
The relevant JSON now looks something like this:
["InstagramSecurityConfig",[],{"csrf_token":"abcdefg"},1234]
Tatsh
reviewed
Apr 14, 2024
| self._session.headers.update({'x-csrftoken': m.group(1)}) | ||
| m = list(re.finditer(r'{"csrf_token":"([^"]+)"', r.text)) | ||
| assert len(m) == 1, m | ||
| self._session.headers.update({'x-csrftoken': m[0].group(1)}) |
There was a problem hiding this comment.
This assert was only there for typing purposes so you can remove the assert line and then wrap this line in try: ... except IndexError: raise CSRFTokenNotFound (create the exception similar to the ones at the top of client.py).
Also, please do me a favour and fix the quotes on line 228. I know it's not your fault they are there but it's a simple fix so this passes QA.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous regex no longer works because instagram changed schema.
The relevant JSON now looks something like this:
Obviously I changed the token and integer value.