Skip to content

test(query-core): add test case for hydration#8949

Merged
TkDodo merged 16 commits intoTanStack:mainfrom
minseong0324:test/hydration
Apr 14, 2025
Merged

test(query-core): add test case for hydration#8949
TkDodo merged 16 commits intoTanStack:mainfrom
minseong0324:test/hydration

Conversation

@minseong0324
Copy link
Contributor

@minseong0324 minseong0324 commented Apr 3, 2025

improve test coverage of hydration.ts from 85% to 100%.

Before

image

After

image

@nx-cloud
Copy link

nx-cloud bot commented Apr 3, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit c045bb7.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 5m 49s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 59s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-13 18:09:44 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 3, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8949

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8949

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8949

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8949

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8949

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8949

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8949

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8949

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8949

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8949

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8949

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8949

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8949

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8949

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8949

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8949

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8949

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8949

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8949

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8949

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8949

commit: c045bb7

@codecov
Copy link

codecov bot commented Apr 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.01%. Comparing base (967c231) to head (c045bb7).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8949       +/-   ##
===========================================
+ Coverage   44.46%   59.01%   +14.54%     
===========================================
  Files         204      139       -65     
  Lines        8101     5355     -2746     
  Branches     1791     1407      -384     
===========================================
- Hits         3602     3160      -442     
+ Misses       4067     1908     -2159     
+ Partials      432      287      -145
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 85.42% <ø> (ø)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core 95.95% <ø> (+0.47%) ⬆️
@tanstack/query-devtools 3.61% <ø> (ø)
@tanstack/query-persist-client-core 73.46% <ø> (ø)
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/react-query 95.42% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.48% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 88.15% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.01% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

TkDodo
TkDodo reviewed Apr 6, 2025
View reviewed changes
@minseong0324 minseong0324 requested a review from TkDodo April 8, 2025 17:54
@TkDodo TkDodo merged commit 727230f into TanStack:main Apr 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TkDodo TkDodo Awaiting requested review from TkDodo

Assignees

No one assigned

Labels

package: query-core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@minseong0324 @TkDodo

Comments