fix: added details in history for Bittensor dTAO operations #2288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Consolidated stake and unstake into a single type. Also added TAO <-> ALPHA in history. 
|
0xKheops
requested changes
Jan 7, 2026
Contributor
0xKheops
left a comment
0xKheops
left a comment
There was a problem hiding this comment.
looks great now, but can be further simplified
0xKheops
requested changes
Jan 9, 2026
Comment on lines
43
to
44
| fromTokenId: nativeToken.id, | ||
| toTokenId: nativeToken.id, |
Contributor
There was a problem hiding this comment.
if using native token id for both, the label in the details form will be incorrect for unstake txs.
one of them is not the native token but alpha for netuid 0, can generate its id using subDTaoTokenId("bittensor", 0).
Comment on lines
191
to
195
| defaults={ | ||
| isStake | ||
| ? "Stake <FromTokens /> for <ToTokens />" | ||
| : "Unstake <FromTokens /> for <ToTokens />" | ||
| } |
Contributor
There was a problem hiding this comment.
i18n strings cannot be conditional or they wont be parsed and sent to our translation platform.
sadly we need 2 different <Trans /> components here.
Contributor
There was a problem hiding this comment.
or maybe have the operation name being output by a 3rd entry in the components property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added TAO/Alpha information for dTAO staking events (unstake/stake).
It seems like even for swap details (SimpleSwap), we still just say "Confirmed/Failed", so I didn't change the dTAO history items to stay "Stake/Unstake" (but this can easily be added if we want).