Added pageinate-links custom tag support & improved compatibility #56
+217
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allows `<paginate-links>` custom tag * Click handler could be placed at various layers * Updated README with these features * Fixed browser compatibility: many browsers (such as Edge) does not support `forEach()` function on `NodeList` (return value of `querySelectAll()`).
|
Ah, just ran into this issue with forEach() on NodeList. Was trying to use polyfill.io but even they don't support it since it's not actually in spec. Would be great if this can be merged in. Thanks for the work @chazeon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<paginate-links>custom tag (as is mentioned in issue Pagination links not displaying correctly with Semantic-UI #46) to support a wider range of UI frameworkREADME.mdwith these introductions of this featureforEach()function onNodeList(return value ofquerySelectAll()).