Add ability to add and remove speakers from teams in admin interface#2838
Add ability to add and remove speakers from teams in admin interface#2838TrudeauOkech wants to merge 3 commits intoTabbycatDebate:developfrom
Conversation
tienne-B
left a comment
tienne-B
left a comment
There was a problem hiding this comment.
Sorry for the delay in the review!
| </ul> | ||
| </details> | ||
|
|
||
| {% haspermission "add.team" as add_team_perm %} |
There was a problem hiding this comment.
Should this section be renamed? I think that having these action buttons in a section called "Custom Questions" could lead to people thinking that the answers are what will be deleted, not the speaker itself.
Also, a different permission should be used (like "delete speaker") for deletion.
There was a problem hiding this comment.
Yeah that's a fair point, will rename it. And will add a separate permission for deletion.
There was a problem hiding this comment.
Small things, but we should use form_class for both new form views, and then add the object in get_form_kwargs() rather than overriding get_form()
Also, for creation, I'm not sure the registration form would be the best, as a lot of fields may be missing, and admins may not want to answer the custom fields.
There was a problem hiding this comment.
Will do, good catch.
There was a problem hiding this comment.
Makes sense, I'll swap it out for a plain ModelForm on Speaker instead.
There was a problem hiding this comment.
Just an idea, but maybe add an "Edit" button to the top of the registration card to send the user to the team's "Edit DB" page?
There was a problem hiding this comment.
Good idea, I'll add that.
2 participants
Should fix #2689
