Created All preferences Page#2739
Open
JWPCode wants to merge 3 commits intoTabbycatDebate:developfrom
Open
Conversation
tienne-B
reviewed
Oct 3, 2025
Comment on lines
+27
to
+37
| @tournament_preferences_registry.register | ||
| class DummyAllSectionsPreference(StringPreference): | ||
| section = all_sections | ||
| name = 'dummy_all_sections' | ||
| default = '' | ||
| verbose_name = 'All Sections Placeholder' | ||
|
|
||
| def get_field_kwargs(self): | ||
| kwargs = super().get_field_kwargs() | ||
| kwargs['widget'] = forms.HiddenInput | ||
| return kwargs |
Member
There was a problem hiding this comment.
Why do we need a dummy preference?
Contributor
Author
There was a problem hiding this comment.
Its been a while since I did it sorry, but Its because of how the preferences are handled and how they have been put into sections. The default when there is no argument passed doesn't work with this set up, So we needed a new section to pass, that could then have the other sections added to, however it needs an initial preference to be returned or it throws an error
Co-authored-by: Teymour Aldridge <teymour@reasoning.page>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw Issue #2586 requesting a page that had all preferences listed. This Page Has all preferences listed grouped by the section they appear. Under the assumption this page will be used with ctrl/cmd+f there are no section headers. Adding section headers requires more substantial code changes especially to templates and such, I also didn't think they would be necessary with the current seperate pages for each section.