-
-
Notifications
You must be signed in to change notification settings - Fork 10
Migrating from Google Maps to maplibre_gl #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…s grpc uses the wrong one
…ry aware is clearly flawed (untested, of course)
…icon instead of the primary focus (prev red) and tertiary focus (prev blue) being marked differently. The text thing seems to be an issue with the NavigaTUM styling, so that's gonna be an ordeal.
…te vs Google Maps (still missing location button)
…gaTUM instead of the high resolution one because it was off center and this is good enough
|
This is pretty incredible, thanks Nathan! (FYI @CommanderStorm) |
CommanderStorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work and thanks a ton for tackling this problem!
I have added a code comments below regarding the camera usage and a few comments.
Other than that LGTM
| import 'package:flutter/material.dart'; | ||
| import 'package:flutter/services.dart'; | ||
| import 'package:flutter_riverpod/flutter_riverpod.dart'; | ||
| import 'package:google_maps_flutter/google_maps_flutter.dart'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completely removing google_maps_flutter, including offline components, by transitioning away from usage of google_maps_flutter defined objects being put through a translation layer in favor of natively defined maplibre_gl objects
If you think this is a better way, I will go with that.
I have not looked how much work that would be 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think long term it would be preferable to have fewer dependencies but it breaks the containment of the map widget itself so it's quite a lot of effort. Ultimately the only true impact is a file size difference and probably a few microseconds.
In response to #308 [Feature] Migrating from Google Maps to maplibre/flutter-maplibre-gl
Changes
Byproducts
Known degradations
Future features
Example photos