Fixes to build and use libRSF on Ubuntu 24.04 Noble #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate from Ceres LocalParameterization to Manifold API
Summary
This PR migrates libRSF from Ceres Solver's deprecated
LocalParameterizationAPI to the modernManifoldAPI. This change ensures compatibility with newer versions of Ceres Solver and follows the library's recommended migration path.Changes
Core API Migration
LocalParametrization.h: Migrated all local parameterization classes to use the
ManifoldAPI:AngleLocalParameterization: AddedMinus()method and updated toAutoDiffManifoldUnitCircleLocalParameterization: AddedMinus()method with angle extraction logicQuaternionLocalParameterization: AddedMinus()method using quaternion error computationceres::Manifold*instead ofceres::LocalParameterization*operator()toPlus()method (required by Manifold API)FactorGraph.cpp: Updated parameter block setup and manipulation:
ProductParameterizationwithProductManifoldIdentityParameterizationwithEuclideanManifoldSubsetParameterizationwithSubsetManifoldSetParameterization()toSetManifold()ParameterBlockLocalSize()toParameterBlockTangentSize()FactorGraph.h: Updated comment to reflect
manifold_ownershipinstead of deprecatedlocal_parameterization_ownershipBuild System Updates
glogto the link libraries (required dependency)#include <glog/logging.h>headerGeographicLib Fix
GeographictoGeographicLibto match the correct library nameTechnical Details
The Manifold API requires both
Plus()andMinus()methods:Plus(x, delta, x_plus_delta): Maps from tangent space to manifoldMinus(y, x, y_minus_x): Maps from manifold to tangent space (new requirement)This migration maintains backward compatibility in terms of functionality while updating to the modern Ceres API.
Testing
Compatibility
Related Issues
Addresses compatibility with newer Ceres Solver versions where
LocalParameterizationis deprecated.