Change the default values of :func:~.reduce_repeated_substring parameters for general use#20
Open
mohamadmansourX wants to merge 3 commits intoTRoboto:mainfrom
Open
Change the default values of :func:~.reduce_repeated_substring parameters for general use#20mohamadmansourX wants to merge 3 commits intoTRoboto:mainfrom
~.reduce_repeated_substring parameters for general use#20mohamadmansourX wants to merge 3 commits intoTRoboto:mainfrom
Conversation
Since this repo is meant to be focusing on Arabic language, I'd suggest the change the minimum repeated character from 3 to 4 since in Arabic 3 consecutive occurrences of the same character do exists. Check the below two examples: - تشتتت https://www.almaany.com/ar/dict/ar-ar/%D8%AA%D8%B4%D8%AA%D8%AA%D8%AA/ - تتتابع https://www.maajim.com/dictionary/%D8%AA%D8%AA%D8%AA%D8%A7%D8%A8%D8%B9
Collaborator
|
Thanks for contributing to Maha.
I support that to keep like these words without changing.
Thanks again for your contribution! |
Owner
|
Thank you for pointing this out. I am in favor of changing the default value of In the meanwhile, please fix the tests. |
TRoboto
changed the title
~.reduce_repeated_substring parameters for general use
TRoboto
force-pushed
the
main
branch
23 times, most recently
from
0db1663 to
ca5be90
Compare
TRoboto
force-pushed
the
main
branch
3 times, most recently
from
e2ecbc9 to
945141c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this Repo is meant to be focusing on Arabic language, I'd like to suggest to change the minimum repeated character filter from 3 to 4 since in Arabic language 3 consecutive occurrences of the same character do exists.
(Note even with the use of Shadda, there will still exist three consecutive occurrences)
Check the below two examples: