allow explicit priority config in SlicesRuleDefinition #1436
+22
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guesshe
force-pushed
the
guesshe-explicit-priority-in-slicesruledefinition
branch
from
7f235cb to
84d08d6
Compare
hankem
force-pushed
the
guesshe-explicit-priority-in-slicesruledefinition
branch
from
de37753 to
4583bb4
Compare
hankem
reviewed
Apr 13, 2025
| @@ -67,12 +67,28 @@ public GivenSlices matching(String packageIdentifier) { | |||
| return new GivenSlicesInternal(Priority.MEDIUM, Slices.matching(packageIdentifier)); | |||
There was a problem hiding this comment.
We could reduce a tiny bit of code duplication if this now delegated to the new method:
Suggested change
| return new GivenSlicesInternal(Priority.MEDIUM, Slices.matching(packageIdentifier)); | |
| return matching(packageIdentifier, Priority.MEDIUM); |
| public GivenSlices matching(String packageIdentifier, Priority priority) { | ||
| return new GivenSlicesInternal(priority, Slices.matching(packageIdentifier)); | ||
| } | ||
|
|
||
| /** | ||
| * @see Slices#assignedFrom(SliceAssignment) | ||
| */ | ||
| @PublicAPI(usage = ACCESS) | ||
| public GivenSlices assignedFrom(SliceAssignment assignment) { | ||
| return new GivenSlicesInternal(Priority.MEDIUM, Slices.assignedFrom(assignment)); |
There was a problem hiding this comment.
This could likewise delegate to the other new method:
Suggested change
| return new GivenSlicesInternal(Priority.MEDIUM, Slices.assignedFrom(assignment)); | |
| return assignedFrom(assignment, Priority.MEDIUM); |
Sweet! Thanks for tidying it up! |
Resolves: TNG#1434 Signed-off-by: riverhe <[email protected]>
hankem
force-pushed
the
guesshe-explicit-priority-in-slicesruledefinition
branch
from
334bf78 to
17a1160
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1434